-
Notifications
You must be signed in to change notification settings - Fork 168
[pre-commit.ci] pre-commit autoupdate #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4971de to
026b8bb
Compare
7b071e4 to
f028b19
Compare
Including also a unit test with mixed outofbounds and valid locations
2119 spatial hashing
instead of the kernel-time; which is not well defined in vectorized form
Also implementing better error handling
Now that the index_search for v4 is taking shape (e.g. #2144), this PR cleans up clutter by removing functions that are not needed anymore, or will be implemented in a different way
Using correct mesh_type and conversion Also had to change the yi-indexing. To explore why!
Using vectorized version of dot-product calculation as suggested by @michaeldenes in #2152 (comment)
Leveraging some of the work I did for xarray ;)
Co-authored-by: Erik van Sebille <[email protected]>
This ensures that "no-hit" queries return coordinates with the right dimensions
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Bugfix/2239 oob spatialhash
updates: - [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0) - [github.com/astral-sh/ruff-pre-commit: v0.12.5 → v0.13.2](astral-sh/ruff-pre-commit@v0.12.5...v0.13.2)
5b447fd to
03acffb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates: