Implement fieldset._load_timesteps() attempt 2 #2161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvansebille
changed the title
This was referenced Aug 25, 2025
By only using _load_timesteps when is_dask_collection(data)
Member
Author
|
Closing this PR as not planned (we get reasonable performance without having to load full timesteps into memory) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a reimplementation of #2098 but then for the vectorized version of the kernel, building also on the Morton encoding in #2158. It is mostly for performance testing purposes, see also Parcels-code/parcels-benchmarks#7
mainfor v3 changes,v4-devfor v4 changes)