Deal with search interpolation errors #2164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@fluidnumerics-joe, can you also use this PR to add your fix for the graceful error handling in the Morton encoding hash query (#2162)? |
Member
Author
This was now handled in #2166 |
VeckoTheGecko
requested changes
Sep 2, 2025
Contributor
|
just some minor feedback - happy to merge after that |
Co-authored-by: Nick Hodgskin <[email protected]>
…terpolation_errors' into deal_with_search_interpolation_errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr cleans up some of the error coding in Parcels v4. Specifically, it throws an InterpolationError when the return value of an
Interpolatorisnp.nanmainfor v3 changes,v4-devfor v4 changes)