Refactor param handling of pset.execute
#2171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt should never be nat
Test will be implemented in test_particleset_execute
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Nevermind, fixed in c5df886 - didn't see that at first, 5pm struggle 😅 |
erikvansebille
approved these changes
Sep 2, 2025
Co-authored-by: Erik van Sebille <[email protected]>
VeckoTheGecko
changed the title
pset.execute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the body of
pset.executeout into_get_simulation_start_and_end_timesto help with code maintainability, and make things easier to parse. The execution flow in_get_simulation_start_and_end_timesis also easier to follow, and tests have been added to help with informative error messaging.mainfor v3 changes,v4-devfor v4 changes)