-
Notifications
You must be signed in to change notification settings - Fork 168
Use element indices particle.ei in curvilinear search
#2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@fluidnumerics-joe, there's a failing unit test in the uxgrid part: with detailed error Probably has to do with Can you see if you can fix this for uxgrid? |
|
Taking a look :) |
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some minor clarifications but otherwise LGTM
|
Happy to merge when you're ready @erikvansebille :) |
While the Morton encoding for the curvilinear search (#2175) is very fast, it turns out to be even faster to use the element indices (
particle.ei) in the search.Using the benchmark script in OceanParcels/parcels-benchmarks@
9a39630(#5), we get the following speed-up:where execution 1 is with the Morton search (since
particle.ei = None) and execution 2 is with the code in this PR to use theparticle.ei.Note that this is the most optimal case where particles don't move between searches, but that is actually very often the case because