Skip to content

Using AdvectionRK4 for reference of Kernel signature check #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikvansebille merged 1 commit into from
Sep 15, 2025
Merged

Using AdvectionRK4 for reference of Kernel signature check #2215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions parcels/kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

from parcels.application_kernels.advection import (
AdvectionAnalytical,
AdvectionRK4,
AdvectionRK45,
)
from parcels.basegrid import GridType
Expand All @@ -24,7 +25,6 @@
_raise_time_extrapolation_error,
)
from parcels.tools.warnings import KernelWarning
from tests.common_kernels import DoNothing

if TYPE_CHECKING:
from collections.abc import Callable
Expand Down Expand Up @@ -69,7 +69,7 @@ def __init__(
for f in pyfuncs:
if not isinstance(f, types.FunctionType):
raise TypeError(f"Argument pyfunc should be a function or list of functions. Got {type(f)}")
_assert_same_function_signature(f, ref=DoNothing, context="Kernel")
_assert_same_function_signature(f, ref=AdvectionRK4, context="Kernel")

if len(pyfuncs) == 0:
raise ValueError("List of `pyfuncs` should have at least one function.")
Expand Down
Loading