Skip to content

Conversation

@fluidnumerics-joe
Copy link
Contributor

No description provided.

@fluidnumerics-joe
Copy link
Contributor Author

One concern with this PR at the moment is that, when run under pytest, the test_fesom2_square_delaunay_antimeridian_eval gets killed on my system with an OOM issue. This is related to @erikvansebille 's concerns about high memory usage in the morton hash table construction .

@fluidnumerics-joe fluidnumerics-joe changed the title [DRAFT] Feature/uxgrid morton hashing Feature/uxgrid morton hashing Sep 17, 2025
@fluidnumerics-joe
Copy link
Contributor Author

In the generic unstructured antimeridian sample dataset, I did find some bad elements (They have a single longitude value but span the whole range of latitude). Looking to see if this dataset needs some correction.

@fluidnumerics-joe fluidnumerics-joe marked this pull request as ready for review September 17, 2025 15:36
@fluidnumerics-joe
Copy link
Contributor Author

I was able to track down the bad elements in the antimeridian test case that were causing an insanely large number of hash table entries ( O(10^6) ). The boundary mask needed to be corrected. I also adjusted this _fesom2_square_delaunay_antimeridian domain boundary to be a bit smaller to keep the memory footprint manageable for unit testing. This one should be good to go, pending a review.

@fluidnumerics-joe fluidnumerics-joe merged commit a9eaa88 into v4-dev Sep 21, 2025
9 checks passed
@fluidnumerics-joe fluidnumerics-joe deleted the feature/uxgrid-morton-hashing branch September 21, 2025 13:20
@github-project-automation github-project-automation bot moved this from Backlog to Done in Parcels development Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants