Skip to content

Conversation

@VeckoTheGecko
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko commented Sep 25, 2025

Note that if there is a W the UV field isn't added - is this in line with v3 @erikvansebille ?

@erikvansebille
Copy link
Member

Note that if there is a W the UV field isn't added - is this in line with v3 @erikvansebille ?

Yes, that's correct. We by default have either a UV or a UVW VectorField

@erikvansebille
Copy link
Member

Should we also add #2235 (comment) into this PR?

@VeckoTheGecko
Copy link
Contributor Author

VeckoTheGecko commented Sep 25, 2025

Should we also add #2235 (comment) into this PR?

I want to do that now separately alongside a bunch of other runtime warnings we're getting Actually, I can do it here - wont take long

@VeckoTheGecko
Copy link
Contributor Author

I want to do that now separately alongside a bunch of other runtime warnings we're getting Actually, I can do it here - wont take long

I think we only see these in the tests actually - let's merge this

Copy link
Member

@erikvansebille erikvansebille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that most (all?) copernicusmarine products use "upward sea water velocity" as default name for "W".

However, that this means that, since depth is decreasing downward, we will have to negate the W field by default...

Note that this is also done in v3:
https://github.com/OceanParcels/Parcels/blob/4073545a8ac4a0a49469277eb7603dd6a4c6cb0a/parcels/fieldset.py#L656-L657

Co-authored-by: Erik van Sebille <[email protected]>
@VeckoTheGecko VeckoTheGecko enabled auto-merge (squash) September 26, 2025 07:55
@VeckoTheGecko VeckoTheGecko merged commit cd52d14 into Parcels-code:v4-dev Sep 26, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Parcels development Sep 26, 2025
@VeckoTheGecko VeckoTheGecko deleted the copernicus-update branch October 7, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Update .from_copernicusmarine to parse vertical velocities FieldSet.from_copernicusmarine() and non-advection kernels

2 participants