-
Notifications
You must be signed in to change notification settings - Fork 168
Update from_copernicusmarine ingestion #2238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from_copernicusmarine ingestion #2238
Conversation
Yes, that's correct. We by default have either a |
|
Should we also add #2235 (comment) into this PR? |
|
I think we only see these in the tests actually - let's merge this |
erikvansebille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked that most (all?) copernicusmarine products use "upward sea water velocity" as default name for "W".
However, that this means that, since depth is decreasing downward, we will have to negate the W field by default...
Note that this is also done in v3:
https://github.com/OceanParcels/Parcels/blob/4073545a8ac4a0a49469277eb7603dd6a4c6cb0a/parcels/fieldset.py#L656-L657
Co-authored-by: Erik van Sebille <[email protected]>
Co-authored-by: Erik van Sebille <[email protected]>
for more information, see https://pre-commit.ci
Update
from_copernicusmarineto parse in W fields from CF naming - fixes Update.from_copernicusmarineto parse vertical velocities #2237Update
from_copernicusmarineallow no currents (no log messages are emitted here) - fixesFieldSet.from_copernicusmarine()and non-advection kernels #2236Note that if there is a W the UV field isn't added - is this in line with v3 @erikvansebille ?