Adding support for subsecond dt values in pset.execute #2242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses #2241
erikvansebille
added a commit
that referenced
this pull request
Oct 2, 2025
The error message in #2242 referred to `set_dt_dtype()`, while the method has been renamed to `update_dt_dtype`. This PR fixed the error message
VeckoTheGecko
pushed a commit
that referenced
this pull request
Oct 2, 2025
The error message in #2242 referred to `set_dt_dtype()`, while the method has been renamed to `update_dt_dtype`. This PR fixed the error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, set.execute does not support an input
dt < 1 second(i.e.dt.dtype("ns")because we initialise theparticledata.dt.dtypein seconds, so any input dt smaller than that will be0(and hence the code will go into an infinite loop)Now, we could of course set the default
particledata.dt.dtypein"ns", but the disadvantage is that all thesedts will then be very large numbers. But perhaps a nicer way is to let users update theparticledata.dt.dtypeonly when that is necessary (i.e. when their inputdtis sub second), This PR proposes that.This PR addresses #2241