Changing pset.depth to pset.z throughout code #2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeckoTheGecko
approved these changes
Oct 6, 2025
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
that could be done in the PR, or in another PR?
I think separate would be nice so that it can be easily reviewed - this PR already has a large diff.
Contributor
|
Are we good to merge this? |
erikvansebille
added a commit
that referenced
this pull request
Oct 10, 2025
Also changing particle.depth to particle.z throughout, following #2303
reint-fischer
pushed a commit
to reint-fischer/parcels
that referenced
this pull request
Oct 15, 2025
Also changing particle.depth to particle.z throughout, following Parcels-code#2303
reint-fischer
pushed a commit
to reint-fischer/parcels
that referenced
this pull request
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #2257, by changing
ParticleSet.depthtoParticleSet.zthroughout the codebase and tests.Note that it doesn't change the vertical direction of our internal model for the Fields (#2063) (also renaming from
depthtoz); that could be done in the PR, or in another PR?