[v3] Binder pre amble (port of #2293) #2316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cels-code#2293) Co-authored-by: Nick Hodgskin <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Contributor
Author
|
Ready to review @erikvansebille (note the binder links will only work post-merge due to how RTD builds for PRs) |
Member
|
Hmm, when I open one of the binders I get the error below. Is that expected? |
Contributor
Author
Yes, it should be fixed post merge. Only one way to find out.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #2293 to v3 of Parcels (fixing the repo name in the binder links and link resolve)
Since we have all the redirects for the websites and the repos - I don't think its worth porting #2313 across to this repo as the only difference for users will be branding.