Skip to content

Conversation

@reint-fischer
Copy link
Contributor

I have rewritten the Field sampling tutorial to work with v4 and added it back into the documentation. To do so I needed to change the FieldSet from Peninsula.nc to the Copernicus Marine dataset, which also contains a temperature field. I have also adapted the tutorials to import the kernels using parcels.kernels as per #2309.

There was some unexpected behavior from the delayed particle release, with not all initial values being sampled, which I plan to look into in conjunction with the repeatdt tutorial.

Copy link
Contributor

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(will do a full review tomorrow)* Could we update the workflow in pixi.toml along the lines of

# in pixi.toml
[feature.test.tasks]
tests = "pytest"
-tests-notebooks = "pytest --nbval-lax -k 'argo' docs/examples"
+tests-notebooks = "pytest --nbval-lax -k 'argo or tutorial_output' docs/examples"

so the workflows are run?

*Didn't get around to it today, will try Friday

@github-project-automation github-project-automation bot moved this from Backlog to Ready in Parcels development Oct 8, 2025
@reint-fischer
Copy link
Contributor Author

Thanks for the comments, I have implemented your feedback. In discussion with @erikvansebille I have added a folder “examples_v3” to store the v3 notebooks and examples. As we move them to v4, I will re-add them to the “examples” folder so that pixi run tests-notebooks tests them. Please let me know if you have other thoughts on adding this folder.

I have added all the example python scripts to “examples_v3” too, because they were failing, but I wasn’t sure whether you had already rewritten them, so please let me know if I should add them back to “examples”.

The tutorial_Argofloats.ipynb now fails for me with the error:

Notebook cell execution failed
Cell 1: Timeout of 5 seconds exceeded waiting for output.

Do you know what to do about this?

Copy link
Contributor

@VeckoTheGecko VeckoTheGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

@reint-fischer reint-fischer merged commit 770d424 into Parcels-code:v4-dev Oct 15, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Done in Parcels development Oct 15, 2025
@reint-fischer reint-fischer deleted the sampling-tutorial branch October 15, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants