-
Notifications
You must be signed in to change notification settings - Fork 168
Add Field sampling tutorial v4 #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Field sampling tutorial v4 #2317
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(will do a full review tomorrow)* Could we update the workflow in pixi.toml along the lines of
# in pixi.toml
[feature.test.tasks]
tests = "pytest"
-tests-notebooks = "pytest --nbval-lax -k 'argo' docs/examples"
+tests-notebooks = "pytest --nbval-lax -k 'argo or tutorial_output' docs/examples"so the workflows are run?
*Didn't get around to it today, will try Friday
|
Thanks for the comments, I have implemented your feedback. In discussion with @erikvansebille I have added a folder “examples_v3” to store the v3 notebooks and examples. As we move them to v4, I will re-add them to the “examples” folder so that I have added all the example python scripts to “examples_v3” too, because they were failing, but I wasn’t sure whether you had already rewritten them, so please let me know if I should add them back to “examples”. The tutorial_Argofloats.ipynb now fails for me with the error: Do you know what to do about this? |
b5d3396 to
67d78e4
Compare
67d78e4 to
4493522
Compare
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good :)
I have rewritten the Field sampling tutorial to work with v4 and added it back into the documentation. To do so I needed to change the FieldSet from Peninsula.nc to the Copernicus Marine dataset, which also contains a temperature field. I have also adapted the tutorials to import the kernels using
parcels.kernelsas per #2309.There was some unexpected behavior from the delayed particle release, with not all initial values being sampled, which I plan to look into in conjunction with the repeatdt tutorial.