Support for 1D fields without lon and/or lat #2363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this unit test currently breaks
Contributor
VeckoTheGecko
left a comment
VeckoTheGecko
left a comment
There was a problem hiding this comment.
This PR fixes #2054
Can we update this to "contributes to" - I think this PR is only one element of that issue
VeckoTheGecko
approved these changes
Nov 14, 2025
Contributor
There was a problem hiding this comment.
I think that in future search() can be refactored making it clearer how the grids are handled to make sure that we're covering edge cases.
Something for my (later) todo - no need to make into an issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Fields that don't have longitude and/or latitude dimensions. A relevant example would be 1-dimensional depth profiles.
This PR contributes to #2054