Skip to content

Bugfix PolyTEOS10_bsq kernel #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaeldenes merged 5 commits into from
Oct 31, 2025
Merged

Bugfix PolyTEOS10_bsq kernel #75

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0224fa7
Updating the polyteos kernel to compute the seawater density (and not…
michaeldenes Oct 29, 2025
55dada9
Adding test for PolyTEOS kernel
michaeldenes Oct 31, 2025
c17943b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 31, 2025
cf064b4
Particle should be at 1000m depth for unit test
michaeldenes Oct 31, 2025
8f73e87
Depths was missing from the `create_particleset` function, necessary …
michaeldenes Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions plasticparcels/kernels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,14 +402,24 @@ def PolyTEOS10_bsq(particle, fieldset, time):
Oceanic Technology, 20, 730-741.

"""
Z = - particle.depth # note: use negative depths!
Z = - math.fabs(particle.depth) # note: use negative depths!
SA = fieldset.absolute_salinity[time, particle.depth, particle.lat, particle.lon]
CT = fieldset.conservative_temperature[time, particle.depth, particle.lat, particle.lon]

SAu = 40. * 35.16504 / 35.
CTu = 40.
Zu = 1.0e+04
deltaS = 32.

zz = -Z / Zu
R00 = 4.6494977072e+01
R01 = -5.2099962525e+00
R02 = 2.2601900708e-01
R03 = 6.4326772569e-02
R04 = 1.5616995503e-02
R05 = -1.7243708991e-03
r0 = (((((R05 * zz + R04) * zz + R03) * zz + R02) * zz + R01) * zz + R00) * zz

R000 = 8.0189615746e+02
R100 = 8.6672408165e+02
R200 = -1.7864682637e+03
Expand Down Expand Up @@ -469,8 +479,9 @@ def PolyTEOS10_bsq(particle, fieldset, time):
rz2 = (R022 * tt + R112 * ss + R012) * tt + (R202 * ss + R102) * ss + R002
rz1 = (((R041 * tt + R131 * ss + R031) * tt + (R221 * ss + R121) * ss + R021) * tt + ((R311 * ss + R211) * ss + R111) * ss + R011) * tt + (((R401 * ss + R301) * ss + R201) * ss + R101) * ss + R001
rz0 = (((((R060 * tt + R150 * ss + R050) * tt + (R240 * ss + R140) * ss + R040) * tt + ((R330 * ss + R230) * ss + R130) * ss + R030) * tt + (((R420 * ss + R320) * ss + R220) * ss + R120) * ss + R020) * tt + ((((R510 * ss + R410) * ss + R310) * ss + R210) * ss + R110) * ss + R010) * tt + (((((R600 * ss + R500) * ss + R400) * ss + R300) * ss + R200) * ss + R100) * ss + R000
particle.seawater_density = ((rz3 * zz + rz2) * zz + rz1) * zz + rz0
# particle.sw_surface_density = rz0
r = ((rz3 * zz + rz2) * zz + rz1) * zz + rz0

particle.seawater_density = r0 + r


def VerticalMixing(particle, fieldset, time):
Expand Down
Loading