-
Notifications
You must be signed in to change notification settings - Fork 10
Converting MFP CSV to YAML schedule #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
5c5bf9a
draft script for converting MFP CSV to YAML schedule
iuryt 40c7ff9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 366dede
add openpyxl
iuryt d046444
add mfp_to_yaml function
iuryt e3199fa
add new command to init to accept mfp file as input
iuryt d9fe46a
delete files from scripts/
iuryt 7dc9bd7
deleted scripts files
iuryt a79433c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 11332f8
export the schedule body instead of saving file
iuryt ad54992
change name of cli param and adapt for new mfp_to_yaml function
iuryt 66adb18
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2672afa
add warning message for time entry on yaml
iuryt a370641
change to pydantic and change name of variables
iuryt b87d944
add XBT
iuryt eba08b8
accept nonetype time
iuryt c0a52ac
change to Waypoint to BaseModel and add field_serializer for instrume…
iuryt 526d2af
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c51043d
remove restriction for version
iuryt f3daaa7
add checking for columns from excel file
iuryt 4c59420
add unit tests
iuryt b67b15d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 6f63cd4
Add update comments and var naming
VeckoTheGecko 222df85
Remove buffering from mfp conversion
VeckoTheGecko c94567b
update references to Waypoint
VeckoTheGecko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VeckoTheGecko @ammedd
While using pydantic, I had to change this to accept nonetype time, but this means that when we do
schedule.from_yaml()forfetchit will not give any error, right? What should we do?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. I thought that pydantic would have a way of disabling validation during the initialisation of the object, but looking further at the documentation its looking that that isn't possible ... . Longterm it would be good to have
start_timeandend_timenot none, but perhaps thats something for a future PR