Renaming the default_* fields to ship_* fields #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammedd
approved these changes
Feb 19, 2025
Collaborator
ammedd
left a comment
ammedd
left a comment
There was a problem hiding this comment.
Thanks. Looks good. Readthedocs build failed, I asked @VeckoTheGecko.
Collaborator
|
Related to tox-dev/sphinx-autodoc-typehints#523 |
VeckoTheGecko
force-pushed
the
rename_default_fields_to_ship_fields
branch
from
b5a69c5 to
3b9ea8a
Compare
VeckoTheGecko
force-pushed
the
rename_default_fields_to_ship_fields
branch
from
3b9ea8a to
046044f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This clarifies that these fields are used for the ship-based instruments (xbt, ctd, ship_underwater_st)