Skip to content

Conversation

@erikvansebille
Copy link
Member

@erikvansebille erikvansebille commented Feb 14, 2025

@erikvansebille
Copy link
Member Author

FYI, readthedocs on #133 also failed, even though that PR had nothing to do with documentation...

@VeckoTheGecko
Copy link
Collaborator

VeckoTheGecko commented Feb 20, 2025

Brought this up to date with main (after #137 was merged) and did some cleanup.

@VeckoTheGecko
Copy link
Collaborator

I've separated out the DrifterConfig.period changes into a separate branch (drifter-period) to be included in another PR.

  • wasn't 100% clear the motivation for it/how it would be used in the codebase/what it's default would be (would there be cases where it would have a default?)
  • was causing ci to fail

cc @ammedd

Copy link
Collaborator

@ammedd ammedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better. Thanks

@VeckoTheGecko VeckoTheGecko merged commit fa0b431 into main Feb 20, 2025
10 checks passed
@VeckoTheGecko VeckoTheGecko deleted the ship_spped_in_knots branch February 20, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small issues to discuss/fix

4 participants