Clearer error message when the column Instrument is missing #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
erikvansebille
commented
Feb 19, 2025
erikvansebille
commented
- Closes #xxxx
- Tests added
- Re-ran README.md help commands if the CLI has changed
ammedd
reviewed
Feb 20, 2025
|
|
||
| if set(["XBT", "CTD", "SHIP_UNDERWATER_ST"]) & set(instruments_in_schedule): | ||
| if ( | ||
| (set(["XBT", "CTD", "SHIP_UNDERWATER_ST"]) & set(instruments_in_schedule)) |
Collaborator
There was a problem hiding this comment.
"SHIP_UNDERWATER_ST" can be removed here
ammedd
approved these changes
Feb 20, 2025
Collaborator
ammedd
left a comment
ammedd
left a comment
There was a problem hiding this comment.
Much better error messages. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.