-
Notifications
You must be signed in to change notification settings - Fork 10
Add schedule verification step to fetch command #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi reviewers, I'm aware that this PR changes more things than the issue it is associated with, but I felt some reorganizing of the code was in order as I was making the changes. If it's too much (in particular the moving of the The commits follow a coherent chronological order, and should be viewed individually to make sense of the changes. |
6350175 to
5d1ffdc
Compare
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Just have some changes, mainly around the fixtures/tests and function signatures/readability
0228f8d to
7692979
Compare
|
Hey @VeckoTheGecko I was a bit busy the last 2 weeks, so only now making the requested changes. But here they are! Thanks for the review 👌 |
VeckoTheGecko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good. Thanks for getting back to this @diogomatoschaves ! Looks good to me now :)
4536f20 to
dc9cac7
Compare
|
There was an error in the tests that had slipped through the cracks. Hopefully now all tests should pass |
|
Thanks! |
for more information, see https://pre-commit.ci
31e911d to
2f103e5
Compare
Closes Run verify_schedule at start of fetch command #162
Moves
_get_scheduleand_get_ship_configto utils file.Refactors validation of
scheduleandship_config, which become methods of theScheduleandShipConfigclasses respectively.Makes
get_instruments_in_schedulea method of theScheduleclassAdds more tests for the
ScheduleandShipConfigclasses.Moves fetch function to its own module
Adds schedule verification step at the beginning of the fetch command
Tests added