Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Play SDK Console verification file #121

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

wzieba
Copy link
Collaborator

@wzieba wzieba commented Jan 13, 2025

Generated during ownership verification. It is not considered a secret.

Testing

Build the sdk (assemble) and unzip generated .aar and then .jar. The verification file should be under META-INF/com/parsley/parsely/verification.properties

Generated during ownership verification. It is not considered a secret
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.46%. Comparing base (47696a4) to head (8ab8ae6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage   70.46%   70.46%           
=======================================
  Files          22       22           
  Lines         413      413           
  Branches       51       51           
=======================================
  Hits          291      291           
  Misses        107      107           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzieba wzieba requested a review from ParaskP7 January 13, 2025 11:08
@wzieba wzieba marked this pull request as ready for review January 13, 2025 11:08
Copy link
Collaborator

@ParaskP7 ParaskP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 @wzieba I am approving this because I followed the testing instructions and everything works as expected. I was able to locate the verification.properties within both the debug and release version of the .aar file, within the classer.jar file within the .aar itself.

PS: Could you please maybe share the documentation as well so that I could briefly read about this requirement, ownership verification, it not being considered a secret and all, just for my FYI. 🙏

@wzieba
Copy link
Collaborator Author

wzieba commented Jan 13, 2025

Could you please maybe share the documentation as well

Sure, you can find more details at https://support.google.com/googleplay/android-developer/answer/12244916#Verify_ownership

@wzieba wzieba merged commit dbb8f5e into main Jan 13, 2025
3 checks passed
@wzieba wzieba deleted the sdk_console_verification branch January 13, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants