-
Notifications
You must be signed in to change notification settings - Fork 2
#5 Taste 공통 컴포넌트 개발 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
wlrnjs
reviewed
Sep 25, 2025
Member
wlrnjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 코멘트 확인해주세요!
Member
Author
|
리뷰 피드백 반영하였습니다. |
huuitae
reviewed
Sep 26, 2025
Contributor
huuitae
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다!
huuitae
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 PR 내용 요약
✅ 작업 내용 상세
taste, block-gauge 두 컴포넌트 파일로 나누어 작업하였습니다.
useState()를 사용하여 블럭 클릭시 블럭 게이지 관련 데이터가 저장되게끔 구현 해놨습니다.
반응형 구현을 진행하였고 스토리북으로 테스트 하였습니다.
neutral 관련 커스텀 컬러 2가지 추가했습니다.
💬 참고 사항
모달 taste 컴포넌트가 디자인이 달라서 따로 구현해야 할 것 같습니다.
문제가 없다면 리뷰 ( Mobile ) taste 컴포넌트, 모달 ( Pc, Tablet, Mobile ) taste 개발도 시작하겠습니다.