[#8] 와인 타입 선택 컴포넌트 제작 #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
junye0l
reviewed
Sep 26, 2025
| htmlFor={name} | ||
| className={cn( | ||
| "py-[7px] pl-2 pr-3", | ||
| "flex items-center justify-center gap-[6px]", |
Member
There was a problem hiding this comment.
"flex items-center justify-center" -> "flex-center" 으로 변경해도 좋을 것 같아요!
| errorMsg: string; | ||
| } | ||
|
|
||
| interface TextInputValue extends InputValue { |
Member
There was a problem hiding this comment.
interface InputValue {
placeholder: string;
errorMsg: string;
title?: string;
}
두 인터페이스를 합쳐서 title 값만 옵셔널로 지정하는건 어떤가요?
…into design/type-select
…into design/type-select
junye0l
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 PR 내용 요약
와인 타입을 선택하는 컴포넌트 입니다.
✅ 작업 내용 상세
와인 타입 선택
hover,checked디자인이 없어 칩 컴포넌트와 동일한 스타일로 디자인 했습니다.사용된 이미지는
/public/image/wine-type디렉토리에 추가했습니다📸 스크린샷 (선택사항)
💬 참고 사항
TextInput컴포넌트는 아직 미완성입니다SelectType컴포넌트만 확인 부탁드립니다!