[#8] 좋아요 버튼 컴포넌트 제작 #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
junye0l
reviewed
Sep 29, 2025
| import IconButton from "./icon-button"; | ||
| import ArrowButton from "./arrow-button"; | ||
| import ICON_MAP from "../icon/icon-map"; | ||
| import LikeButton from "./like-button"; |
Member
There was a problem hiding this comment.
스토리북 파일에 추가 되었다면, chromatic 라벨을 추가하는게 좋을 것 같아요!
wlrnjs
reviewed
Sep 29, 2025
| */ | ||
| const LikeButton = ({ isLike, count, ...props }: LikeButtonProps) => { | ||
| return ( | ||
| <div> |
Comment on lines
25
to
27
| "cursor-pointer rounded-lg py-1 pl-2 pr-3", | ||
| "mobile:h-8 mobile:gap-[2px]", | ||
| "tablet:h-8 tablet:gap-[2px]", |
Member
There was a problem hiding this comment.
현재 mobile:h-8 mobile:gap-[2px], tablet:h-8 tablet:gap-[2px]는 동일한 값이라
base 스타일로 h-8 gap-[2px]만 선언해도 동일하게 동작합니다.
PC 구간만 오버라이드하면 코드가 더 간결해질 것 같아요
Contributor
Author
There was a problem hiding this comment.
적용해본 결과 모바일 해상도에서는 원하는 디자인으로 나오지만 태블릿 해상도에서는 디자인 적용이 되지 않습니다.
"mobile:h-8 mobile:gap-[2px]", 이 부분은 삭제하고 "tablet:h-8 tablet:gap-[2px]", 이 부분은 남겨놓아야할 것 같습니다.
Member
There was a problem hiding this comment.
테스트 해봤는데 Button 컴포넌트 내부에 있는 스타일 요소 때문에 제가 말씀드린 방식으로는 적용되지 않는 것 같네요.
이런 경우에는 휘태님께서 작성해주신 코드를 사용하는게 올바른것 같습니다.
원래는 저 방식이 맞는데 왜 안되나 했네요.. 확인 감사합니다!
wlrnjs
previously approved these changes
Sep 30, 2025
junye0l
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 PR 내용 요약
좋아요 버튼 컴포넌트입니다.
✅ 작업 내용 상세
부모 컴포넌트에서
isLikeprop을 전달받아 버튼의 스타일을 변경하도록 제작했습니다.PC 반응형 스타일에서
gap이6px인데 가로로 너무 길어보여서4px로 줄여보았습니다.좋아요 개수 표기 문구를 수정했습니다 십만 자리 수 까지는
~만의 형태로 표기됩니다.📸 스크린샷 (선택사항)
💬 참고 사항