fix: Footer social media icons redirect to the same placeholder link (href="#") (Issue #57) - #58
fix: Footer social media icons redirect to the same placeholder link (href="#") (Issue #57)#58Pranita422 wants to merge 1 commit into
href="#") (Issue #57)#58Conversation
|
@PriyankaYadavHarikesh is attempting to deploy a commit to the Parv Aggarwal's projects Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe frontend updates Vite from ChangesVite version update
Footer social links
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@barterly-frontend/src/components/layout/Footer.jsx`:
- Around line 88-101: Update the external social anchors in the Footer
component, including the X, LinkedIn, and Instagram links, to open in a new tab
with target="_blank" and rel="noopener noreferrer".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2f738244-15f2-4df6-b004-8c91d3db3ef5
⛔ Files ignored due to path filters (1)
barterly-frontend/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
barterly-frontend/package.jsonbarterly-frontend/src/components/layout/Footer.jsx
What Changed
href="#") from the social media icons.Why
The footer contained X, LinkedIn, and Instagram icons that all pointed to the same placeholder link (
href="#"). This caused a confusing user experience because users expected each icon to have a meaningful destination.How To Test
Screenshots
Related Issue
Closes #57
Checklist
CONTRIBUTING.md.Notes
Since the project currently does not have official social media profiles, this pull request updates the placeholder link behaviour based on the proposed solution discussed in the related issue. If official social media accounts become available in the future, the links can be updated accordingly.
Summary by CodeRabbit
Bug Fixes
Chores