Skip to content

fix: Footer social media icons redirect to the same placeholder link (href="#") (Issue #57) - #58

Open
Pranita422 wants to merge 1 commit into
Parvaggarwal01:mainfrom
Pranita422:main
Open

fix: Footer social media icons redirect to the same placeholder link (href="#") (Issue #57)#58
Pranita422 wants to merge 1 commit into
Parvaggarwal01:mainfrom
Pranita422:main

Conversation

@Pranita422

@Pranita422 Pranita422 commented Jul 21, 2026

Copy link
Copy Markdown

What Changed

  • Updated the footer social media links implementation.
  • Removed the placeholder navigation (href="#") from the social media icons.
  • Improved the footer navigation behaviour to avoid misleading users.

Why

The footer contained X, LinkedIn, and Instagram icons that all pointed to the same placeholder link (href="#"). This caused a confusing user experience because users expected each icon to have a meaningful destination.

How To Test

  1. Start the application locally.
  2. Open the website in a browser.
  3. Scroll to the footer.
  4. Verify the behaviour of the social media icons.
  5. Ensure there are no console errors.

Screenshots

image image

Related Issue

Closes #57

Checklist

  • I have read CONTRIBUTING.md.
  • I kept this pull request focused on one issue.
  • I ran the relevant checks locally.
  • I added or updated tests where appropriate.
  • I added screenshots or screen recordings for UI changes.
  • I documented any known limitations or follow-up work.

Notes

Since the project currently does not have official social media profiles, this pull request updates the placeholder link behaviour based on the proposed solution discussed in the related issue. If official social media accounts become available in the future, the links can be updated accordingly.

Summary by CodeRabbit

  • Bug Fixes

    • Updated footer social media links so the X, LinkedIn, and Instagram icons now open their respective websites instead of placeholder links.
  • Chores

    • Updated the Vite development tooling to a newer version.

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

@PriyankaYadavHarikesh is attempting to deploy a commit to the Parv Aggarwal's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The frontend updates Vite from ^7.3.1 to ^7.3.6 and replaces footer social-link placeholders with X, LinkedIn, and Instagram URLs.

Changes

Vite version update

Layer / File(s) Summary
Update Vite development dependency
barterly-frontend/package.json
The Vite development dependency is updated from ^7.3.1 to ^7.3.6.

Footer social links

Layer / File(s) Summary
Replace footer social placeholders
barterly-frontend/src/components/layout/Footer.jsx
The X, LinkedIn, and Instagram anchors now use platform-specific external URLs instead of #.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The Vite package.json version bump is unrelated to the footer social-link fix and appears out of scope. Move the Vite dependency update to a separate maintenance PR unless it is required for this footer change.
Linked Issues check ❓ Inconclusive The footer URLs were updated, but the summary doesn't verify the required target and rel attributes for external links. Confirm the three social anchors also include target="_blank" and rel="noopener noreferrer" if they open externally.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: replacing footer social placeholder links with real destinations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@barterly-frontend/src/components/layout/Footer.jsx`:
- Around line 88-101: Update the external social anchors in the Footer
component, including the X, LinkedIn, and Instagram links, to open in a new tab
with target="_blank" and rel="noopener noreferrer".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2f738244-15f2-4df6-b004-8c91d3db3ef5

📥 Commits

Reviewing files that changed from the base of the PR and between d2c111a and 1b428cf.

⛔ Files ignored due to path filters (1)
  • barterly-frontend/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • barterly-frontend/package.json
  • barterly-frontend/src/components/layout/Footer.jsx

Comment thread barterly-frontend/src/components/layout/Footer.jsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Footer social media icons redirect to the same placeholder link (href="#")

2 participants