Update dependencies and fix http-proxy-middleware compatibility

.github/workflows/pull-request.yml

@@ -5,7 +5,7 @@ on:
 
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
 
@@ -16,7 +16,7 @@ jobs:
 
       - name: Install dependencies
         run: npm ci
-      
+
       - name: Test
         run: npm run test
 

app.js

@@ -151,7 +151,7 @@ export async function configure(startStamp) {
     if (config.serveStore) {
         const got = require('got');
         const rewrite = require('express-urlrewrite');
-        const proxy = require('http-proxy-middleware');
+        const { createProxyMiddleware } = require('http-proxy-middleware');
         const uploadServer = `http://${config.uploader.hostname || 'localhost'}:${config.uploader.port}`;
         const downloadServer = `http://${config.downloader.hostname || 'localhost'}:${config.downloader.port}`;
 
@@ -197,8 +197,8 @@ export async function configure(startStamp) {
             res.redirect(302, '/img/caps/avatarth.png');
         });
 
-        app.use(['/upload', '/uploadava'], proxy({ target: uploadServer, logLevel: 'warn' }));
-        app.use('/download', proxy({ target: downloadServer, logLevel: 'warn' }));
+        app.use(['/upload', '/uploadava'], createProxyMiddleware({ target: uploadServer, logger }));
+        app.use('/download', createProxyMiddleware({ target: downloadServer, logger }));
 
         // Seal store paths, ie request that achieve this handler will receive 404
         app.get(/^\/(?:_a|_prn)(?:\/.*)$/, static404);

controllers/__tests__/admin.test.js

@@ -139,7 +139,7 @@ describe('admin', () => {
 
             await comment.create(data);
 
-            await expect(CommentN.count({ obj: news })).resolves.toBe(1);
+            await expect(CommentN.countDocuments({ obj: news })).resolves.toBe(1);
             await expect(admin.deleteNews(news)).rejects.toThrow(new NoticeError(constants.NEWS_CONTAINS_COMMENTS));
         });
     });

controllers/__tests__/comment.test.js

@@ -49,7 +49,7 @@ describe('comment', () => {
             expect(result.comment.txt).toMatch(data.txt);
             expect(result.comment.user).toMatch('user1');
 
-            await expect(CommentN.count({ obj: news })).resolves.toBe(1);
+            await expect(CommentN.countDocuments({ obj: news })).resolves.toBe(1);
         });
     });
 
@@ -93,7 +93,7 @@ describe('comment', () => {
             await comment.create(data);
 
             // Sanity check.
-            await expect(CommentN.count({ obj: news })).resolves.toBe(4);
+            await expect(CommentN.countDocuments({ obj: news })).resolves.toBe(4);
 
             const comments = await comment.giveForUser({ login: 'user1', type: 'news' });