chore(comments): strip SDK-version and removed-thing archaeology - #389
Merged
Conversation
Comments that named the SDK release a line was written against (v3.1: ...), listed constants and document types that no longer exist, or called a still-supported shape legacy told a reader about a past state rather than the code in front of them. They are gone or reworded to say what the code does now: the older stored shapes are described as such where a fallback still reads them.
Deploying yappr-v2 with
|
| Latest commit: |
37ed158
|
| Status: | ⚡️ Build in progress... |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comments only; no code changes.
v3.1: Use StateTransitionsFacade…,v3.1: getIdentityContractNonce returns…,(v3.1 SDK returns bigint | undefined)) are removed. The call is the call; the release it arrived in is git history.YAPPR_BLOCK_CONTRACT_ID removed,HASHTAG_CONTRACT_ID and MENTION_CONTRACT_ID removed, the six-line "were removed in contract migration" note aboveDOCUMENT_TYPES) are removed or replaced by a one-line statement of where those things live today.plain base64 is an older shape still read,uncompressed JSON string, the shape before compression,the older vault contract) instead of by the word legacy.Left alone: topology comments (
on v3 …,v5's proved ranking…) describe live behaviour that differs by contract shape and are load-bearing.Part of the anti-slop cleanup series (after #370–#388).
Test plan
npm run lint,tsc --noEmit,npm run test,npx knip,npm run buildall green locally🤖 Generated with Claude Code