fix: three findings from the refactor reviews - #391
Merged
Conversation
The profile's load-more path kept a repost cursor that nothing honoured: repostService.getUserReposts returns the whole list, so every second page refetched all reposts and deduplicated them away. Only original posts page now. The optimistic profile save built a payment scheme with split(':') while the service lower-cases it; one exported paymentUriScheme serves both, so a Bitcoin: URI shows the same scheme before and after reload. The composer's private-feed hook left loading true forever when the modal opened without a user.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three pre-existing bugs the review agents surfaced while checking the refactor PRs. Each was present before the refactors; they are fixed here on their own so the refactors stayed behaviour-preserving.
repostService.getUserRepostshas no cursor and returns the full list, so the "load more reposts" branch on the profile page refetched everything and deduplicated it away on each page. The repost cursor state and that branch are removed; only original posts page. First-load behaviour is unchanged.schemewithuri.split(':')[0] + ':'whileunifiedProfileServicelower-cases it, so aBitcoin:URI rendered with a different scheme until reload. One exportedpaymentUriSchemeserves both.useComposePrivateFeedinitialisedloadingto true and returned early without clearing it when there was no user, so the visibility selector stayed in its loading state. It now clears.Part of the anti-slop cleanup series (after #370–#390).
Test plan
npm run lint(zero warnings),tsc --noEmit,npm run test,npx knip,npm run buildall green locallyBitcoin:tip address and see the same scheme icon before and after reload; open compose while logged out and see the selector settle🤖 Generated with Claude Code