Fix dark theme inconsistencies and unrelated layout bugs - #585
Open
anshujod wants to merge 2 commits into
Open
Conversation
- Add theme toggle + dark mode to state.html and recommendations.html - Recolor recommendations.html dark palette to match site (was purple) - Fix orders.html duplicate script tags breaking the theme toggle - Fix malformed duplicate <section> tags in index.html clipping content below the hero (menu, about, contact, footer were hidden) - Fix duplicated team-member markup causing overlapping About Us cards - Add missing .combo-preview CSS fixing button/text overlap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #582 — dark theme was inconsistent across pages. While testing the fix, I also found and fixed an unrelated but serious bug in
index.htmlwhere corrupted HTML was hiding most of the homepage.Dark theme fixes (#582)
state.htmlandrecommendations.htmlnever loaded the theme toggle ormain.js, so a user's saved dark-mode preference was silently ignored on both pages, with no way to switch themes there at all. Added the toggle button and the same dark-mode init/persist logic used elsewhere.recommendations.html's dark mode originally used an off-palette purple/indigo color scheme. Recolored it to match the site's actual dark palette (#1e1e1ebackground,#2a2a2acards,#ff5722/#ffab91accents).orders.htmlhadmain.js(and several other scripts) included twice, so the theme-toggle click handler was attached twice — every click turned dark mode on and immediately back off, making the toggle appear broken. Removed the duplicate<script>tags.Unrelated bug found during testing
index.htmlhad duplicated, unclosed<section id="hero">and<section id="recently-viewed">tags. Because.herohas a fixed viewport height andoverflow: hidden, every section after it in the DOM (Explore by State, Explore Menu, About, Contact, Footer) was structurally trapped inside the hero box and clipped away. Fixed the malformed markup so the rest of the homepage renders again.Test plan
state.html— click the theme toggle, confirm header/nav/cards switch to darkrecommendations.html— click the theme toggle, confirm it switches to the grey/orange dark palette (not purple) with readable contrastorders.html— click the theme toggle, confirm dark mode now actually engages (previously did nothing)index.html— scroll past the hero, confirm Explore Menu, Explore by State, About, Contact, and Footer are all visibleindex.html— About Us section, confirm each team card shows one photo/name/role with no overlapping textindex.html— Smart Food Pairings section, confirm the "Explore Smart Combos" button no longer overlaps the paragraph above itlocalStorageand confirm it's respected on loadScreenshots
state.html
Before:

After:

recommendations.html
orders.html
Before:


After:
index.html — homepage below hero
Before:

After:
