Skip to content

fix: resolve 4 bugs in ChaatBazaar - #596

Open
saurabhhhcodes wants to merge 1 commit into
PatelHarsh2006:mainfrom
saurabhhhcodes:fix/ChaatBazaar-60017
Open

fix: resolve 4 bugs in ChaatBazaar#596
saurabhhhcodes wants to merge 1 commit into
PatelHarsh2006:mainfrom
saurabhhhcodes:fix/ChaatBazaar-60017

Conversation

@saurabhhhcodes

Copy link
Copy Markdown

Description

This PR fixes real bugs found in the codebase:

  • Prevented interval leak: repeated mounts now clear the previous interval before scheduling a new one.
  • Replaced innerHTML assignment with textContent: prevents HTML injection / XSS and is faster since it does not parse markup.
  • Prevented interval leak: repeated mounts now clear the previous interval before scheduling a new one.
  • Guarded JSON.parse on localStorage: corrupted or missing keys previously threw a fatal SyntaxError; now falls back safely.

Type of Change

  • Bug fix (non-breaking change fixing an issue)

How Has This Been Tested?

  • Local manual testing

Checklist

  • My code follows the style guidelines
  • I have performed a self-review

Related Issue

Ref: #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant