Fix accidental poll removal on status edit.#168
Merged
andregasser merged 5 commits intoPattaFeuFeu:masterfrom Mar 31, 2023
Merged
Fix accidental poll removal on status edit.#168andregasser merged 5 commits intoPattaFeuFeu:masterfrom
andregasser merged 5 commits intoPattaFeuFeu:masterfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #168 +/- ##
============================================
- Coverage 44.97% 44.95% -0.03%
- Complexity 230 235 +5
============================================
Files 74 75 +1
Lines 2190 2169 -21
Branches 109 115 +6
============================================
- Hits 985 975 -10
+ Misses 1165 1148 -17
- Partials 40 46 +6
|
andregasser
requested changes
Mar 28, 2023
Collaborator
andregasser
left a comment
There was a problem hiding this comment.
The poll parameters should be refactored into a separat poll data class and the data class itself should then be placed in the *.entity.data package, as discussed in the associated issue.
for use in Mastodon entities (ScheduledStatus) as well as in methods (post/edit/schedulePoll).
Collaborator
Author
|
I've now added the changes as discussed. Turns out, having two classes both named |
Collaborator
|
Sure, that's fine! 👍🏻 |
Collaborator
Author
|
@andregasser Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As detected via #166, editing a status containing a poll using
editStatus()will remove the poll. This clarifies our documentation by stating that:editStatus()editPoll()needs to be retrieved from the existing status first.Removes default values from two poll parameters in
editPoll()to avoid an accidental change when editing.Fixes one unrelated typo in the actual request.