Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linking to pattern candidates and issues #145

Closed
mhinkie opened this issue Mar 17, 2022 · 2 comments
Closed

Enable linking to pattern candidates and issues #145

mhinkie opened this issue Mar 17, 2022 · 2 comments

Comments

@mhinkie
Copy link
Contributor

mhinkie commented Mar 17, 2022

Is your feature request related to a problem? Please describe.
Currently it is not possible to use the address shown for a specific pattern candidate or a specific issue to directly link to this candidate or issure from the outside.
To reproduce:

Describe the solution you'd like
Enable direct linking of pattern candidates and issues similar to how patterns are handled.
E.g. a pattern link http://localhost:1978/pattern-languages/af7780d5-1f97-4536-8da7-4194b093ab1d/d4f7c247-e2bb-4301-ad06-f758fa58f2dc always correctly shows the pattern.

Additional context
Depending on the authentication status sometimes also the "New Issue" and "New Candidate" view is shown upon opening the current links.

For a working implementation refer to the routing for patterns:
src/app/pattern-language-management/pattern-language-management-routing.module.ts
src/app/pattern-language-management/pattern-language-management.module.ts

@mhinkie
Copy link
Contributor Author

mhinkie commented Aug 1, 2022

When rewriting the navigation for issues and candidates examine the state-stores mentioned in #68 (comment)

@mhinkie mhinkie mentioned this issue Aug 1, 2022
@mhinkie
Copy link
Contributor Author

mhinkie commented Nov 23, 2022

Fixed in #160
State-Stores are removed and routing is fixed to load issues and candidate corretly when opened via URL

@mhinkie mhinkie closed this as completed Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant