-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ba meyer master #68
Ba meyer master #68
Conversation
5f4bac0
to
cb64e59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TYueksel I tested the authentification and flow and after creating a user, could get redirected to the UI again (error="invalid_grant", error_description="Invalid redirect: http://localhost:1978 does not match one of the registered values.") - is there any other config I still need to change manually to get it running?
Besides from that, the build failed due to lint errors - please fix it (npm run lint
)
src/app/admin-management/user/user-detail/user-detail.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/component/comment-list-item/comment-list-item.component.scss
Outdated
Show resolved
Hide resolved
src/app/core/component/comment-list/comment-list.component.spec.ts
Outdated
Show resolved
Hide resolved
(this is managed in external system now)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some minor issues left.
src/app/admin-management/user/user-detail/user-detail.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/component/action-button-bar/action-button-bar.component.html
Outdated
Show resolved
Hide resolved
src/app/core/component/comment-list-item/comment-list-item.component.html
Outdated
Show resolved
Hide resolved
src/app/core/component/comment-list-item/comment-list-item.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/component/pattern-language-picker/pattern-language-picker.component.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Final implementation of my BA
Related to https://github.com/PatternAtlas/pattern-atlas-api/pull/19
and PatternAtlas/pattern-atlas-docker#9