-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disable editing buttons #126
Conversation
… disabled Signed-off-by: Marvin Bechtold <[email protected]>
Related to #96 but it implements only a subset of the features |
Signed-off-by: Marvin Bechtold <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe also add a default if the config server is not there or not reachable --> always set the readonly mode?
@lharzenetter The default configuration values which are used if the config server is not reachable are all set to true: pattern-atlas-ui/src/app/core/directives/pattern-atlas-ui-repository-configuration.service.ts Line 41 in 57b37d6
|
Hmm, I guess should make this false, what do you think? |
Signed-off-by: Marvin Bechtold <[email protected]>
Signed-off-by: Marvin Bechtold <[email protected]>
…is allowed to edit the configuration Signed-off-by: Marvin Bechtold <[email protected]>
Signed-off-by: Marvin Bechtold <[email protected]>
Signed-off-by: Marvin Bechtold <[email protected]>
Signed-off-by: Marvin Bechtold <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Marvin Bechtold <[email protected]>
This PR removes the buttons to edit the markdown of patterns if editing is switched off in the configuration.