Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disable editing buttons #126

Merged
merged 9 commits into from
Dec 10, 2021
Merged

Fix disable editing buttons #126

merged 9 commits into from
Dec 10, 2021

Conversation

mar-be
Copy link
Contributor

@mar-be mar-be commented Dec 1, 2021

This PR removes the buttons to edit the markdown of patterns if editing is switched off in the configuration.

@mar-be mar-be added bug Something isn't working wip Work in progress labels Dec 1, 2021
@mar-be
Copy link
Contributor Author

mar-be commented Dec 1, 2021

Related to #96 but it implements only a subset of the features

@mar-be mar-be removed the wip Work in progress label Dec 8, 2021
Copy link
Member

@lharzenetter lharzenetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe also add a default if the config server is not there or not reachable --> always set the readonly mode?

@mar-be
Copy link
Contributor Author

mar-be commented Dec 8, 2021

@lharzenetter The default configuration values which are used if the config server is not reachable are all set to true:

const initialValues: PatternAtlasUiConfiguration = {

@lharzenetter
Copy link
Member

Hmm, I guess should make this false, what do you think?

Copy link
Member

@lharzenetter lharzenetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Marvin Bechtold <[email protected]>
@mar-be mar-be merged commit 30155a3 into master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants