Skip to content

maint: Remove core/remove and core/url. #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

maint: Remove core/remove and core/url. #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/core/remove.js
View file
Open in desktop

This file was deleted.

63 changes: 0 additions & 63 deletions src/core/url.js
View file
Open in desktop

This file was deleted.

68 changes: 0 additions & 68 deletions src/core/url.test.js
View file
Open in desktop

This file was deleted.

8 changes: 3 additions & 5 deletions src/pat/slides/slides.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
import $ from "jquery";
import registry from "../../core/registry";
import utils from "../../core/utils";
import url from "../../core/url";
import "../../core/remove";

var slides = {
name: "slides",
Expand All @@ -24,9 +22,9 @@ var slides = {
}
await import("slides/src/slides"); // loads ``Presentation`` globally.

var parameters = url.parameters();
if (parameters.slides !== undefined) {
var requested_ids = slides._collapse_ids(parameters.slides);
const parameters = new URL(window.location.href).searchParams;
if (parameters.get("slides") !== null) {
var requested_ids = slides._collapse_ids(parameters.get("slides"));
if (requested_ids) slides._remove_slides($el, requested_ids);
}
$el.each(function () {
Expand Down