Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write All LED Performance Improvement #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bitogre
Copy link

@bitogre bitogre commented Apr 10, 2015

Changes to improve performance if all LEDs are updated at once. The
performance increase come from converting the data just before send to
LEDs instead of as we write each LED data to output buffer.

This change is required to get enough performance for my DMX LED controller project. Let me know if you want me to make any changes.

Changes to improve performance if all LEDs are updated at once.  The
performance increase come from converting the data just before send to
LEDs instead of as we write each LED data to output buffer.
#endif
#ifdef __AVR__
#error "The Audio Library only works with Teensy 3.X. Teensy 2.0 is unsupported."
#error "OctoWS2811 does not work with Teensy 2.0 or Teensy++ 2.0."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the wording change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. I started with an older version and only recently decided to share my changes in GitHub. I also recently upgraded to a newer version I got off PJRC which had the above #if TEENSYDUINO < 121 change. So combining the PJRC version with my older change then merging it with the GitHub version is how I ended up with the version I have in GitHub.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, that makes sense :-)

@ColinHarrington
Copy link

Looks like you ran a code formatter on it. It is hard to make out your changes with all of the whitespace changes squashed into one commit.

@PaulStoffregen
Copy link
Owner

I want to merge this. It's going to take some work to incorporate it into the latest code, and pick out which lines changed aren't just whitespace differences.

At the moment I'm working on improving the SD library, and I have a few urgent bugs to investigate... so it may be a while until I can work on OctoWS2811 again. But I definitely do want to include this, when I can get back to OctoWS2811.

@bitogre
Copy link
Author

bitogre commented Sep 27, 2015

What is the status of this merge? What can I do to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants