feat(linux): add support for serial number filtering#6
feat(linux): add support for serial number filtering#6mgcrea wants to merge 1 commit intoPaulStoffregen:masterfrom
Conversation
|
Why is the filter option used with opening the rebootor device? Can you change the usage documentation to clarify that the serial number is used only for soft reboot? |
|
@PaulStoffregen Was not really sure if it would be needed there, but hard_reboot sounded pretty close to soft_reboot...! I'll fix that. |
mgcrea
force-pushed
the
master
branch
3 times, most recently
from
9cbdbc0 to
67b0756
Compare
|
I recently came across this while trying to solve a similar problem. Would be great to get this merged then I don't have to maintain a custom fork. Thanks. |
|
I'm also maintaining a custom fork with this change and would rather not have to. |
|
@mgcrea Are you still maintaining this repo? It would be great to get this change in. I also have a fork with this change. It seems weird to not include it in the release. |
| } | ||
| } | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Note, this block needs to be above the ifdef LIBUSB_HAS_GET_DRIVER_NP block. Otherwise devices that are not selected (because the serial number doesn't match) will be detached from the kernel and not added back. We should only detach the kernel driver if we're actually going to update the device.
5 participants
A quick hack to enable serialNumber filtering support (to address #5 to flash multiple teensys).
Only patched linux, so not ready for merge but might be useful to somebody.