Making soft_reboot() work on more USB build flags than USB_SERIAL#74
Open
SMattsson wants to merge 1 commit intoPaulStoffregen:masterfrom
Open
Making soft_reboot() work on more USB build flags than USB_SERIAL#74SMattsson wants to merge 1 commit intoPaulStoffregen:masterfrom
SMattsson wants to merge 1 commit intoPaulStoffregen:masterfrom
Conversation
…SB_MIDI_SERIAL, USB_MIDI4_SERIAL and USB_MIDI16_SERIAL
driftregion
reviewed
Feb 10, 2025
| serial_handle = open_usb_device(0x16C0, 0x0483); | ||
| if (!serial_handle) { | ||
| serial_handle = open_usb_device(0x16C0, 0x0489); | ||
| } |
There was a problem hiding this comment.
Please also check for Teensy 4.1 dual serial and triple serial:
if (!serial_handle) {
serial_handle = open_usb_device(0x16C0, 0x048b);
}
if (!serial_handle) {
serial_handle = open_usb_device(0x16C0, 0x048c);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently soft_reboot() only works on builds compiled with USB_SERIAL.
This commit updates the soft_reboot() to be able to reboot builds compiled with USB_MIDI_SERIAL, USB_MIDI4_SERIAL and USB_MIDI16_SERIAL.