Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete Aeroponics Prototype, Documentation #44

Merged
merged 17 commits into from
Oct 13, 2021
Merged

Complete Aeroponics Prototype, Documentation #44

merged 17 commits into from
Oct 13, 2021

Conversation

JLefebvre55
Copy link
Member

@JLefebvre55 JLefebvre55 commented Jun 23, 2021 •
edited
Loading

Briefly introduce the scope of the changes included in this pull request.

Testing

See this README.

Checklist

Put an X in the boxes that apply. I have:

  • Updated relevant project documentation, including (if applicable):
    • Bill(s) of materials (components, printed/manufactured parts; see /.github/BOM_TEMPLATES/);
    • Assembly and testing procedures;
  • Followed appropriate code styling and formatting;
  • Added tests that prove my fix is effective or that my feature works;
  • Referenced related issues;
  • Added proper scope and status labels (i.e. Scope: Review Needed);
  • Mentioned related review teams (i.e. @utagritech/admins);

@JLefebvre55 JLefebvre55 added Type: New Feature New feature Status: In Progress Work on this feature has begun Scope: Deliverable Type: Improvement Modification of existing feature labels Jun 23, 2021
@JLefebvre55 JLefebvre55 added this to the Prototyping - Iteration 1 milestone Jun 23, 2021
@JLefebvre55 JLefebvre55 self-assigned this Jun 23, 2021
This was linked to issues Jun 23, 2021
[DESIGN] - High-Pressure Aeroponics #25
Open
[FEATURE] - CAD Up Aeroponics Hardware #43
Closed
@JLefebvre55 JLefebvre55 changed the title Complete Aeroponics Prototype Documentation Complete Aeroponics Prototype, Documentation Jun 28, 2021
@JLefebvre55 JLefebvre55 linked an issue Jul 1, 2021 that may be closed by this pull request
[FEATURE] - Aeroponics Accumulator Tank Pressure Sensor #48
Open
9 tasks
nchareunsouk
nchareunsouk previously approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@nchareunsouk nchareunsouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nchareunsouk
Copy link
Member

nchareunsouk commented Jul 7, 2021 •
edited
Loading

OOP I reviewed a draft lmao😂

Still looking good tho👍

@JLefebvre55 JLefebvre55 removed this from the Finalize Design milestone Oct 13, 2021
@JLefebvre55
Merge branch 'staging' into deliverable-aeroponics
0be49db
@JLefebvre55
BoM Updates
18d537a 
Finished #50 (comment)
Made sure older listings matched CAD and prototype
Left the ones that were going to be outdated eventually
@JLefebvre55 JLefebvre55 marked this pull request as ready for review October 13, 2021 08:40
@JLefebvre55 JLefebvre55 merged commit dd39994 into staging Oct 13, 2021
@JLefebvre55 JLefebvre55 deleted the deliverable-aeroponics branch October 13, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchareunsouk nchareunsouk nchareunsouk left review comments

Assignees

@JLefebvre55 JLefebvre55

Labels
Status: In Progress Work on this feature has begun Type: Improvement Modification of existing feature Type: New Feature New feature
Projects
None yet
Milestone
No milestone
2 participants
@JLefebvre55 @nchareunsouk