Skip to content

Update index.rst#1444

Merged
Ozaq merged 5 commits intomasterfrom
Add-pedDyn-link-AVM
Feb 7, 2025
Merged

Update index.rst#1444
Ozaq merged 5 commits intomasterfrom
Add-pedDyn-link-AVM

Conversation

@chraibi
Copy link
Copy Markdown
Contributor

@chraibi chraibi commented Feb 5, 2025

Add link to AVM pointing to pedDyn_org

@chraibi chraibi marked this pull request as ready for review February 5, 2025 17:28
@chraibi chraibi requested a review from Ozaq February 5, 2025 17:29
Comment thread docs/source/pedestrian_models/index.rst Outdated
Comment on lines +48 to +55
The errors in the `index.rst` file can be fixed as follows:

1. **Title Overline Too Short**: Ensure the overline matches the length of the title text.

2. **Unexpected Indentation**: Remove unnecessary indentations.

3. **Block Quote Ends Without a Blank Line**: Ensure block quotes are followed by a blank line.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the preamble of the ChatGPT output? 😁 Please remove it

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is github's copilot. It's integrated in the CI when you are frustrated with errors you can't fix. Still too bad.

Do you have an idea what the heck?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something else wrong when building our documentation. I can take a look at it tomorrow

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a problem with sphinx in general, we have the same documentation build error on master: https://github.com/PedestrianDynamics/jupedsim/actions/runs/13204250317

I will merge this change, no reason to keep it back due to a infrastructure issue (that we need to address anyways)

@Ozaq Ozaq merged commit 3cb6004 into master Feb 7, 2025
@Ozaq Ozaq deleted the Add-pedDyn-link-AVM branch February 7, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants