New rounding for the step of the axis #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The step in the axis will now be rounded to 2 digits, which resolve the problem of the floating points
|
For references: #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current axis system has an issue with floating point precision. For instance, if the step value is set to 0.1, we encounter precision errors where values like 9.99 or 10 are represented inaccurately as floating point values with many decimal places.
Changes
I have added functionality to round these values to the second decimal place to mitigate this issue. Additionally, I plan to introduce a new parameter in the graph settings that will allow users to specify the desired level of rounding, or disable it altogether if they prefer.
Screenshots
Future Work
Implement a parameter in the graph configuration to allow users to choose the precision for rounding.
Ensure that the rounding functionality is optional and customizable according to user preferences.