Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to add ShimSetting to config.yml doesn't work #331

Open
kweldon1 opened this issue Oct 23, 2024 · 3 comments
Open

Trying to add ShimSetting to config.yml doesn't work #331

kweldon1 opened this issue Oct 23, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@kweldon1
Copy link

Summary

I'm attempting to use a custom config to add two elements (CoilString and ShimSetting) to the summary.tsv when running

cubids group --config code/config.yml bids_test v1

If I add just the CoilString it works as expected but ShimSetting results in no func files showing up in the summary.tsv.

config differences:
coilstring_config
coilstring_shimsetting_config

add coilstring:
add_coilstring
add coilstring and shimsetting
add_coilstring_shimsetting

Additional details

  • CuBIDS version: 1.1.0
  • Datalad version: n/a

Maybe because ShimSetting is a list not a string?

@kweldon1 kweldon1 added the bug Something isn't working label Oct 23, 2024
@tsalo
Copy link
Member

tsalo commented Oct 23, 2024

That makes sense. See #281. We're planning a CuBIDS sprint at some point so hopefully we can fix this soon.

@kweldon1
Copy link
Author

Oh great! Thanks for looking into it.

@mattcieslak
Copy link
Contributor

I think you won't ever want to use shimsetting in cubids. These arrays are unique per scanning session so you'd end up with each session being its own parameter group. Would it still be useful to have something in the summary that indicates whether a shim setting was present in the sidecar? That would be much more useful at the group level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants