Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up CuBIDS class into functions as much as possible #418

Open
tsalo opened this issue Jan 30, 2025 · 2 comments
Open

Break up CuBIDS class into functions as much as possible #418

tsalo opened this issue Jan 30, 2025 · 2 comments
Labels

Comments

@tsalo
Copy link
Member

tsalo commented Jan 30, 2025

I find testing methods within the CuBIDS class difficult because they all rely so much on the actual class, which requires a lot of stuff (e.g., code directory, dataset), so it would be great to do an audit of the methods of the CuBIDS class to see what can be split out into separate functions.

@tsalo tsalo added the refactor label Jan 30, 2025
@mattcieslak
Copy link
Contributor

I completely agree, it's super cumbersome and I get nervous every time i see link numbers in the thousands. Also, the class attributes are not well-explained anywhere and it would be easier/clearer to document them as inputs to standalone functions

@tsalo
Copy link
Member Author

tsalo commented Jan 31, 2025

At minimum, I think the Datalad methods (init_datalad, datalad_save, is_datalad_clean, datalad_undo_last_commit) could be moved into their own class or separate functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants