Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include variant cluster number/centroid or value in variant renaming recommendations #423

Open
tsalo opened this issue Feb 4, 2025 · 3 comments · May be fixed by #432 or #424
Open

Include variant cluster number/centroid or value in variant renaming recommendations #423

tsalo opened this issue Feb 4, 2025 · 3 comments · May be fixed by #432 or #424
Labels
enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Feb 4, 2025

Summary

I think it would be informative to include the variant's value in the proposed acquisition value.
For example, if you had two echo time variants: one with EchoTimes ranging from 0 - 20 and one with EchoTime = 40 - 60 (assuming the dominant group was 20 - 40), you would get the following variant names:

  • acq-VARIANTEchoTime
  • acq-VARIANTEchoTime (same)

It would be great to have the proposed variant names be something like the following:

Using centroid

  • acq-VARIANTEchoTime10
  • acq-VARIANTEchoTime50

This could be hard with floats though.

Using cluster number

  • acq-VARIANTEchoTime1
  • acq-VARIANTEchoTime2

Less informative, but still better than the current approach, I think.

Additional details

Next steps

@tsalo tsalo added the enhancement New feature or request label Feb 4, 2025
@mattcieslak
Copy link
Contributor

It would be great to get feedback on this. I like the idea of cluster number the most

@tsalo
Copy link
Member Author

tsalo commented Feb 4, 2025

I agree that cluster number is the easiest. We might want to create pseudo-cluster numbers for string and array-of-string fields as well, since the different string values might end up being pretty long.

@singlesp
Copy link
Contributor

singlesp commented Feb 4, 2025

Cluster number would probably be easier. If not already clearly presented then a consolidated table of cluster number to entity value/ranges would be a nice thing to have as well.

@singlesp singlesp linked a pull request Feb 5, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants