Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SLURM array jobs in babs-submit #175

Open
tsalo opened this issue Jul 2, 2024 · 5 comments
Open

Support SLURM array jobs in babs-submit #175

tsalo opened this issue Jul 2, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Jul 2, 2024

Summary

It looks like BABS currently submits a separate job for each subject/session, but an array job would be nice. Proposed by @mattcieslak.

@tsalo tsalo added the enhancement New feature or request label Jul 2, 2024
@mattcieslak
Copy link
Collaborator

@djarecka my memory is fuzzy here - did you at one point start working on this? I remember talking about it

@djarecka
Copy link
Collaborator

djarecka commented Jul 2, 2024

I think at the end we decided to leave it for later, so I haven't added. But I would be happy to take a look

@tientong98
Copy link
Contributor

Hi @djarecka, I'd like to work on adding SLURM array job submission to BABS. @mattcieslak mentioned that you worked on this before, so I want to reach out to see what's the best way for us to work together, maybe I can start by learning from the branch you were working on for this issue?

@djarecka
Copy link
Collaborator

Hi @tientong98 , thanks for reaching. I've been just checking my old branches. And it doesn't look like the work was ever finished, and it was before some other changes to the main babs code, so it's hard to understand changes between branches..

If you want to work on this, perhaps we can have a quick chat next week, or I can point you on github to the places I believe should be changed. And if you already started working, I'm happy to review and test. Let me know what would work best for you!

@tientong98 tientong98 self-assigned this Oct 28, 2024
@tientong98
Copy link
Contributor

tientong98 commented Nov 11, 2024

  1. Change to solely array submission, can submit an array of 1 job, but if max_index > 1, will not submit as separate jobs any more
  2. Deprecate SGE

if people use --all, give a warning about hard limit of number of task per job
remove SGE

check status -- grep subid and sesid (because log files don't have this appended in file name)

babs.py:
generate_job_submit_template
generate_bash_participant_job
babs_submit

babs_status:
if_request_resubmit_this_job --> if_request_resubmit_this_task
df_resubmit_job_specific --> df_resubmit_task_specific

utils.py:
submit_one_job --> submit_array
prepare_job_ind_list --> prepare_job_array_df
df_update_one_job --> df_submit_update and df_status_update
subset by i_task instead of i_job

create_job_status_csv
read_job_status_csv

cli.py:
babs_submit_main
babs_status_main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants