Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an error when using nibabies inputs + nifti processing + atlases #1317

Open
tsalo opened this issue Nov 4, 2024 · 2 comments
Open

Raise an error when using nibabies inputs + nifti processing + atlases #1317

tsalo opened this issue Nov 4, 2024 · 2 comments
Assignees
@tsalo
Labels
breaking-change PRs that change results or interfaces.

Comments

@tsalo
Copy link
Member

tsalo commented Nov 4, 2024 •
edited
Loading

We currently rely on a simple affine transform to get NIfTI atlases from MNI152NLin6Asym to MNIInfant, which is pretty terrible. That shouldn't affect HBCD, since HBCD uses CIFTI processing.
@tsalo tsalo self-assigned this Nov 4, 2024
@tsalo
Copy link
Member Author

tsalo commented Nov 4, 2024

I'll just raise an error and remove the bad MNIInfant-to-MNI152NLin6 transform.

@tsalo tsalo changed the title Add a warning when using nibabies inputs + nifti processing + atlases Raise an error when using nibabies inputs + nifti processing + atlases Nov 5, 2024
@tsalo tsalo added the breaking-change PRs that change results or interfaces. label Nov 8, 2024
@tsalo
Copy link
Member Author

tsalo commented Nov 18, 2024 •
edited
Loading

I realized that the transform is used for some figures with CIFTI processing as well, so I'll need to rethink this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsalo tsalo

Labels
breaking-change PRs that change results or interfaces.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsalo