Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Time improvements #1504

Draft
wants to merge 3 commits into
base: eochoa/2025-02-03/static-alloca
Choose a base branch
from

Conversation

erick-xanadu
Copy link
Contributor

Context:

Description of the Change:

  • disable printing unless requested by the user
  • disable async pass unless async is requested by user
  • disable MLIR verifier

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@erick-xanadu erick-xanadu changed the base branch from main to eochoa/2025-02-03/static-alloca February 7, 2025 15:46
@erick-xanadu erick-xanadu marked this pull request as draft February 7, 2025 15:48
@dime10
Copy link
Contributor

dime10 commented Feb 7, 2025

Any concerns about disabling the verifier? Or should consider verification as something we do only in "debug" mode?

@erick-xanadu
Copy link
Contributor Author

erick-xanadu commented Feb 7, 2025

Or should consider verification as something we do only in "debug" mode?

I think if we code things correctly, we could at least disable verification for a lot of code. I think this PR/epic is mostly about detecting opportunities and how much they would benefit us. There's still plenty of room for changing the implementation, like let's say, enabling the verifier in only certain passes (like quantum).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants