Radiation Insulation Refactor Reopen#607
Open
FslashN wants to merge 14 commits intoPentestSS13:masterfrom
Open
Radiation Insulation Refactor Reopen#607FslashN wants to merge 14 commits intoPentestSS13:masterfrom
FslashN wants to merge 14 commits intoPentestSS13:masterfrom
Conversation
Makes some adjustment to the way radiation waves spread through insulation. Previously as a radiation wave expanded, insulation (like walls, for example), did very little to stem the overall strength of the wave. With the change: Insulation blockers have a greater impact on the overall insulation effect, reducing the radiation wave intensity. Greater insulation values also have more impact than before. Only the best insulation is taken per tile, so it is not possible to stack insulation values. This change is done for sanity and to reduce computation. Insulating blockers were expanded and adjusted. Blast doors now have great insulation, for example. Additionally, if you open a door, it will have an impact on the overall radiation wave as the door no longer will act as insulation. Previously, doors and other obstacles that could open and closed always counted as an insulation blocker.
…FslashN/Pentest-Test into Radiation-Insulation-Adjustment
Modularizes stuff, thanks to @Ossa88 for a lot of the original modularization work.
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…Pentest-Test into NEW-RAD-REFACTOR-AAAAAA
Looks like some lines were removed.
I forgot to actually remove the changes to some individual files.
Reverting a few more lines I missed.
Forgot to remove two lines. Oops.
Collaborator
|
Love how there was a merge conflict that wasnt a real merge conflict and github only told me well after i merged small things |
Contributor
Author
|
It's failing for some strange reason. Not really sure. |
Collaborator
Thats the DMI 5 checker from paradise... it might be down atm Just allow the other tests as those are generally more important. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Branched copy of: (#606)
Why It's Good For The Game
As the previous commit but all the modularization issues are now ironed out.
Changelog
🆑
refactor: Refactored radiation spread code as well as insulation.