Skip to content

fix: add null check for room before adding to DevManager #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndorin merged 1 commit into from
Mar 31, 2025
Merged

fix: add null check for room before adding to DevManager #1230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/PepperDash.Essentials/ControlSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,11 +483,13 @@ public void LoadRooms()
{
var room = Core.DeviceFactory.GetDevice(roomConfig);

DeviceManager.AddDevice(room);
if (room is ICustomMobileControl)
if(room == null)
{
Debug.LogWarning("ERROR: Cannot load unknown room type '{roomType:l}', key '{roomKey:l}'.", roomConfig.Type, roomConfig.Key);
Comment thread
andrew-welker marked this conversation as resolved.
continue;
}

DeviceManager.AddDevice(room);
} catch (Exception ex)
{
Debug.LogMessage(ex, "Exception loading room {roomKey}:{roomType}", null, roomConfig.Key, roomConfig.Type);
Expand Down