Release#1233
Merged
Merged
Conversation
Add IHasWebview interface
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new interface to support WebView functionality in devices, specifying methods for showing and hiding the WebView and a property to indicate its visibility.
- Introduces IHasWebView interface.
- Provides clear contracts for WebView actions.
- Isolates WebView-specific functionality for better code organization.
Comments suppressed due to low confidence (1)
src/PepperDash.Essentials.Core/DeviceTypeInterfaces/IHasWebView.cs:11
- [nitpick] Consider renaming 'WebviewIsVisible' to 'IsWebViewVisible' to better align with Boolean property naming conventions.
bool WebviewIsVisible { get; }
aknous
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.