Temp to dev#1257
Merged
Merged
Conversation
fix: ILightingScenesDynamic inherits from ILightingScenes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges changes from the "Temp" branch into "dev" to improve interface consistency and flexibility.
- ILightingScenesDynamic is updated to extend ILightingScenes, consolidating scene-related functionality.
- ISelectableItems is refactored to introduce a generic TValue parameter while preserving a shorthand interface for backward compatibility.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/PepperDash.Essentials.Core/Lighting/Lighting Interfaces.cs | ILightingScenesDynamic now extends ILightingScenes to promote interface consistency. |
| src/PepperDash.Essentials.Core/DeviceTypeInterfaces/ISelectableItems.cs | Introduced a generic TValue parameter for ISelectableItems and added an overload for backward compatibility. |
ndorin
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.